Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment lockfiles auto-update, including asv_runner. #5503

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

Replaces #5502

asv_runner is now an expected presence in Conda environments used by Airspeed Velocity. I didn't catch this since originally we are making slightly unconventional use of environments with ASV (read more here).


Consult Iris pull request check list

@trexfeathers trexfeathers added the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c53481e) 89.37% compared to head (eee433c) 89.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5503   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files          89       89           
  Lines       22446    22446           
  Branches     5387     5387           
=======================================
  Hits        20061    20061           
  Misses       1639     1639           
  Partials      746      746           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trexfeathers
Copy link
Contributor Author

trexfeathers commented Sep 19, 2023

The ❌ run actually demonstrates that adding asv_runner works:

  • Benchmarking 4bcb283 is successful, because this environment includes asv_runner.
  • Benchmarking 064e6ee is a failure, because this pre-dates the inclusion of asv_runner.

Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to merge this in!

@ESadek-MO ESadek-MO merged commit 10cec69 into SciTools:main Sep 19, 2023
17 of 18 checks passed
@trexfeathers
Copy link
Contributor Author

Thanks @ESadek-MO!

@trexfeathers trexfeathers deleted the asv_runner-2 branch May 3, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants