-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update .gitignore #461
update .gitignore #461
Conversation
Is this perhaps something we should be covering in our templating solution? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think this is all good, and in comparison with the existing includes all that currently covers 👍
It's also very close to github/gitignore/Python.gitignore
So the templating idea does seem a really good one.
Given the existence of a very usable template elsewhere = https://github.com/github/gitignore as suggested,
do we want to
- (1) reference that directly in our templating actions, or
- (2) make an scitools-specific snapshot copy of that, and maybe ..
- (2a) .. template that (standard scitools version) against the latest in github/gitignore ?
Ok from offline conversation with @trexfeathers , the templating approach does have value, but we will consider that separately + elsewhere (in Scitools/.github) SciTools/.github#25 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage 89.51% 89.51%
=======================================
Files 8 8
Lines 2450 2450
Branches 416 416
=======================================
Hits 2193 2193
Misses 161 161
Partials 96 96 ☔ View full report in Codecov by Sentry. |
Merging even though the iris-source tests fail : #463 or similar will eventually fix |
This pull-request updates the
.gitignore
base on https://github.com/github/gitignore.