Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "ContributingGuide" for latest llama.cpp #951

Closed
wants to merge 3 commits into from
Closed

Update "ContributingGuide" for latest llama.cpp #951

wants to merge 3 commits into from

Conversation

scritch1sm
Copy link
Contributor

No description provided.

martindevans
martindevans requested changes Oct 15, 2024
View reviewed changes
docs/ContributingGuide.md Outdated

```bash
mkdir build && cd build
cmake .. -DLLAMA_CUBLAS=ON -DBUILD_SHARED_LIBS=ON
cmake .. -DGGML_CUDAS=ON -DBUILD_SHARED_LIBS=ON
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be GGML_CUDA?

llama.cpp Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've committed an update to llama.cpp, can you undo that and just submit the changes to ContributingGuide.md. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah crud. sorry about that. didn't notice that snuck in there.

@scritch1sm scritch1sm closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martindevans martindevans martindevans requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scritch1sm @martindevans