Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix R2RExceptions, run pre-commit, remove password validation #1789

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Jan 9, 2025

Important

Remove password validation, fix R2RExceptions, and apply pre-commit formatting changes.

  • Behavior:
    • Removed password validation logic in users_router.py.
    • Updated requestPasswordReset in users.ts to handle email as plain text.
  • Error Handling:
    • Improved handling of R2RException in users_router.py and r2r_auth.py.
  • Formatting:
    • Ran pre-commit hooks resulting in formatting changes in users.py, users_router.py, and management_service.py.
  • Misc:
    • Minor whitespace and comment adjustments in README.md and users.py.

This description was created by Ellipsis for 2207dbb. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2207dbb in 33 seconds

More details
  • Looked at 461 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. py/core/main/api/v3/users_router.py:143
  • Draft comment:
    Remove commented-out password validation logic to maintain code cleanliness and avoid confusion.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR removes password validation logic from the register method in users_router.py. This change is consistent with the PR title and description. However, the commented-out code should be removed entirely to maintain code cleanliness and avoid confusion.
2. js/sdk/src/v3/clients/users.ts:242
  • Draft comment:
    Set Content-Type to application/json instead of text/plain to match typical API request format.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The requestPasswordReset method in users.ts now accepts a string instead of an object. This change is consistent with the PR title and description. However, the Content-Type header should be set to application/json instead of text/plain to match the typical API request format.

Workflow ID: wflow_UDAri4Xsmuclhvq0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 1cff015 into main Jan 9, 2025
14 of 15 checks passed
@NolanTrem NolanTrem deleted the Nolan/R2RExceptions branch January 9, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant