Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site package installation location #1779

Merged
merged 12 commits into from
Jan 8, 2025
Merged

Fix site package installation location #1779

merged 12 commits into from
Jan 8, 2025

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Jan 8, 2025

Important

Relocates Docker Compose files, updates paths, cleans up code, and modifies version retrieval and configuration paths.

  • Docker Compose Files:
    • Moved compose.yaml, compose.full.yaml, and compose.full_with_replicas.yaml to r2r/ directory.
    • Updated get_compose_files() in docker_utils.py to reflect new paths.
  • Code Cleanup:
    • Removed debug print statements from create_user_api_key() in users_router.py.
    • Deleted ingestion_workflow.py.
  • Version Retrieval:
    • Changed version retrieval to use importlib.metadata in telemetry_decorator.py and __init__.py.
  • Miscellaneous:
    • Updated pyproject.toml to version 3.3.24 and adjusted include paths.

This description was created by Ellipsis for 231fae5. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to afb4295 in 20 seconds

More details
  • Looked at 971 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/telemetry/telemetry_decorator.py:7
  • Draft comment:
    The toml dependency is no longer needed since version retrieval now uses importlib.metadata. Consider removing it from the dependencies in pyproject.toml.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR removes the use of toml for version retrieval and replaces it with importlib.metadata. However, the toml dependency is still present in pyproject.toml. This dependency is no longer needed and should be removed to clean up the dependencies.

Workflow ID: wflow_XekzxfWUdiFRNiz1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on fb3b3dc in 23 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/tests/unit/test_config.py:14
  • Draft comment:
    The path to 'r2r.toml' has been updated in the main config file. Update the test to use the new path:
    config_path = Path(__file__).parent.parent.parent / "r2r" / "r2r.toml"
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_jJxPA5xBHoyl6ko6


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 01503c8 in 13 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/tests/unit/test_config.py:143
  • Draft comment:
    Ensure consistency in file paths. The path to 'r2r.toml' was updated here, but similar updates should be checked throughout the codebase to avoid path-related errors.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_Tpp44yP6GfQ6I7zV


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 231fae5 in 14 seconds

More details
  • Looked at 19 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/pyproject.toml:21
  • Draft comment:
    The update to specify formats for sdist and wheel in the include paths is a good practice for clarity and ensuring correct file inclusion in distributions.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The include paths in pyproject.toml have been updated to specify formats for sdist and wheel. This is a good practice for clarity and ensuring the correct files are included in distributions.

Workflow ID: wflow_Dw8YFEXvLjVQ1oEW


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit cff489c into main Jan 8, 2025
14 checks passed
@NolanTrem NolanTrem deleted the Nolan/SitePackage branch January 8, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant