-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix site package installation location #1779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to afb4295 in 20 seconds
More details
- Looked at
971
lines of code in10
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/core/telemetry/telemetry_decorator.py:7
- Draft comment:
Thetoml
dependency is no longer needed since version retrieval now usesimportlib.metadata
. Consider removing it from the dependencies inpyproject.toml
. - Reason this comment was not posted:
Confidence changes required:50%
The PR removes the use oftoml
for version retrieval and replaces it withimportlib.metadata
. However, thetoml
dependency is still present inpyproject.toml
. This dependency is no longer needed and should be removed to clean up the dependencies.
Workflow ID: wflow_XekzxfWUdiFRNiz1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on fb3b3dc in 23 seconds
More details
- Looked at
27
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/tests/unit/test_config.py:14
- Draft comment:
The path to 'r2r.toml' has been updated in the main config file. Update the test to use the new path:
config_path = Path(__file__).parent.parent.parent / "r2r" / "r2r.toml"
- Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_jJxPA5xBHoyl6ko6
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 01503c8 in 13 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/tests/unit/test_config.py:143
- Draft comment:
Ensure consistency in file paths. The path to 'r2r.toml' was updated here, but similar updates should be checked throughout the codebase to avoid path-related errors. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_Tpp44yP6GfQ6I7zV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 231fae5 in 14 seconds
More details
- Looked at
19
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/pyproject.toml:21
- Draft comment:
The update to specify formats forsdist
andwheel
in theinclude
paths is a good practice for clarity and ensuring correct file inclusion in distributions. - Reason this comment was not posted:
Confidence changes required:0%
Theinclude
paths inpyproject.toml
have been updated to specify formats forsdist
andwheel
. This is a good practice for clarity and ensuring the correct files are included in distributions.
Workflow ID: wflow_Dw8YFEXvLjVQ1oEW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Relocates Docker Compose files, updates paths, cleans up code, and modifies version retrieval and configuration paths.
compose.yaml
,compose.full.yaml
, andcompose.full_with_replicas.yaml
tor2r/
directory.get_compose_files()
indocker_utils.py
to reflect new paths.print
statements fromcreate_user_api_key()
inusers_router.py
.ingestion_workflow.py
.importlib.metadata
intelemetry_decorator.py
and__init__.py
.pyproject.toml
to version3.3.24
and adjustedinclude
paths.This description was created by for 231fae5. It will automatically update as commits are pushed.