Fix agent bug, remove aliases #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 6471a79 in 49 seconds
More details
- Looked at
794lines of code in11files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. py/shared/abstractions/kg.py:173
- Draft comment:
The alias forgraphrag_communitiesis still present. Consider removing it if aliases are no longer used. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_HeIm3gY520ukbgRp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
emrgnt-cmplxty
added a commit
that referenced
this pull request
Dec 6, 2024
* Feature/add web search (#1662) * add web search to rag agent * add web search to rag agent * Fix agent bug, remove alias (#1661) * Log Streaming (#1663) * Fix agent bug, remove alias * Allow ws on logs * up (#1664) * up * add ingestion settings too * up * up * up * up --------- Co-authored-by: Nolan Tremelling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR removes deprecated aliases, refactors search and agent handling, and updates versioning.
graph.py,kg.py,llm.py,search.py, anduser.py.agent()inretrieval_service.pyto handle message and messages input more robustly.retrieval_service.py.IndexMeasureenum frommodels.tsxtotypes.ts.ChunkSearchSettings,GenerationConfig, andHybridSearchSettingsfrommodels.tsxtotypes.ts.r2rClient.tsto useRecord<string, any>for search settings.package.jsonfrom0.4.4to0.4.5.This description was created by
for 6471a79. It will automatically update as commits are pushed.