Compile-time precision set, Pi->PI, inverse-var weighed average & reducer #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
principled control of precision. While maybe obvious, the "principle" here is just that uncertainties themselves have very limited credible precision. This is especially salient when considering values derived from propagated uncertainty, such as "sigma distances" where said sigma parameter is taken to roughly correspond to unit Gaussian/Normal probability scales. That's just a fairly rough correspondence, often papered over with both generous and heuristic bounds like "5 sigma" to decide if results are to be believed.
`-d:nimFatOldSystem` non-duplicative).
the error; `cligen/strUt.fmtUncertain` rounds value to same decimal). 810bdfb changed the default here from 2 to 3, but some users might even want 1.
users do `nim c --hint:Name:on --styleCheck=error --styleCheck=usages`.
with a URI justifying the weights.
Vindaar
reviewed
Oct 15, 2024
| @@ -90,7 +90,7 @@ logic to types other than =float=! | |||
| Feel free to perform error propagation on =unchained= types for | |||
| example: | |||
| #+begin_src nim | |||
| import unchained, meausuremancer | |||
There was a problem hiding this comment.
One of those funny typos a QWERTY user is going to wonder how I managed it. 🤣
Vindaar
reviewed
Oct 15, 2024
measuremancer.nim
Outdated
Comment on lines
608
to
609
| ## Average however many uncertain values in `x` into one overall estimate. | ||
| ## `x` can also be any `openArray[Measurement[F]]`. |
There was a problem hiding this comment.
As we said in private discussion, maybe add another sentence that this computes a weighted mean.
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
Allow compile-time setting of printing precision (number of places for
the error;
cligen/strUt.fmtUncertainrounds value to same decimal).Pi->PIbecause that is howstd/math.nimspells it. This letsusers do
nim c --hint:Name:on --styleCheck=error --styleCheck=usages.Add inverse-var weighted averaging operator & varargs/openArray reducer
with a URI justifying the weights.