Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding safetestsets showed some potentially unwanted interaction between tests.
f(t, y_nv, ydot_nv, user_data)
is not really being used, instead it seems like a previously defined 3 argument version is doing all the work. Might want to check if that is the desired behavior.The downstream CI might not be able to handle packages with
_jll
in their name, which will require an upstream fix.There is also a deprecation message I don't quite understand.
But it is using NullParameters?
https://github.com/SciML/Sundials.jl/blob/master/test/common_interface/jacobians.jl#L37