This repository was archived by the owner on May 15, 2025. It is now read-only.
Backport ITP bugfixes from DiffEqBase in high precision contexts #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of issues on ITP that we found on SciML/DiffEqBase.jl#917
Specifically:
I also extended the bracketing tests to cover cases of
IntervalNonlinearProblem
with a reversed tspan (ietspan[2] < tspan[1]
). I am not sure if this is intended behavior; I assume it is since it works for the previous methods and the corresponding problem can be created. If this is not intended, we can remove those tests but I think it should error atIntervalNonlinearProblem
creation time, then.Another point: return behaviour is slightly different from the DiffEqBase implementation, where the solution has to fulfill
iszero(f(nextfloat(t_sol))) || f(t_sol) * f(nextfloat(tsol)) < 0.0
. Here, iff(t) = 0.0
thent
is returned as the solution, which I guess makes more sense for other purposes.