Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove recompile_invalidations #152

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Remove recompile_invalidations #152

merged 2 commits into from
Jun 27, 2024

Commits on Jun 27, 2024

  1. Remove recompile_invalidations 

    `@recompile_invalidations` should only be used in very specific scenarios, and this is not one of those scenarios. Also, there are big changes being done with https://github.com/SciML/CommonWorldInvalidations.jl. With that, we only need to `@recompile_invalidations` on a few entry points. In particular, Static.jl, Symbolics.jl, and preferably ForwardDiff.jl and StaticArrays.jl would adopt it too. But this means that in order to handle all of this effectively, in SciML we only need to apply it on Static.jl, Symbolics.jl, and SciMLBase.jl and the whole ecosystem should be fine.

In any case, this library doesn't need it. It shouldn't make a tangible difference in compile times, while it increases precompile times by a lot.
    @ChrisRackauckas
    ChrisRackauckas authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a66a21a View commit details
    Browse the repository at this point in the history

  2. Update src/SimpleNonlinearSolve.jl 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @ChrisRackauckas @github-actions
    ChrisRackauckas and github-actions[bot] authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9f21d9a View commit details
    Browse the repository at this point in the history