Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DifferentiationInterface compat to 0.5 #150

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented May 30, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

I recently released DifferentiationInterface v0.5. The major breaking change is that AutoSparse backends can only compute Jacobians and Hessians, and the other operators are no longer supported.

My philosophy is to be very minimalist in DI. As a result, downstream packages may have to combine several backend objects to fulfill all their needs. For instance, the user could provide a first order backend for gradients, and a sparse second-order backend for Hessians.

This change doesn't seem breaking for SimpleNonlinearSolve, but it's better to take it into account early and not allow DI v0.4, so that the SciML ecosystem adjusts accordingly.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (6b682af) to head (2d4e6d5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   90.34%   90.50%   +0.15%     
==========================================
  Files          21       21              
  Lines        1202     1200       -2     
==========================================
  Hits         1086     1086              
+ Misses        116      114       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review May 31, 2024 08:33
@gdalle
Copy link
Contributor Author

gdalle commented Jun 3, 2024

@avik-pal I think this one is an easy merge ;)

@gdalle
Copy link
Contributor Author

gdalle commented Jun 4, 2024

@ChrisRackauckas ?

@ChrisRackauckas ChrisRackauckas merged commit e111b23 into SciML:main Jun 4, 2024
12 of 19 checks passed
@gdalle gdalle deleted the gd/bump_di branch June 4, 2024 19:06
@gdalle
Copy link
Contributor Author

gdalle commented Jun 7, 2024

Thanks for merging @ChrisRackauckas! Could you maybe bump the patch version and release this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants