Skip to content

use LazyBufferCache instead of FixedSizeDiffCache #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use LazyBufferCache instead of FixedSizeDiffCache #1191

wants to merge 1 commit into from

Conversation

jClugstor
Copy link
Member

@jClugstor jClugstor commented Apr 30, 2025 •
edited
Loading

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

This makes EnzymeVJP use LazyBufferCache instead of FixedSizeDiffCache to avoid problems with reinterpret and Enzyme.

@ChrisRackauckas
Copy link
Member

This shouldn't be needed now?

@jClugstor
Copy link
Member Author

Yeah, I'll close it

@jClugstor jClugstor closed this Apr 30, 2025
@jClugstor jClugstor reopened this May 1, 2025
@jClugstor
Copy link
Member Author

@ChrisRackauckas this fixes the Core2 tests.

@ChrisRackauckas
Copy link
Member

But there's a lot of other broken tests it creates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jClugstor @ChrisRackauckas