Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use split = false system for remake autodiff tests #808

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

why split=false?

@AayushSabharwal
Copy link
Member Author

Two reasons:

  1. The tests were written assuming a parameter vector. They actually replaced the MTKParameters object with an Array via remake. The test working was pure coincidence with MTK internals and because the MTKParameters object only had a tunables vector.
  2. Gradient w.r.t parameters not working with MTKParameters SciMLSensitivity.jl#1130

@ChrisRackauckas ChrisRackauckas merged commit 70ae7fb into SciML:master Oct 7, 2024
35 of 43 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fix-tests branch October 7, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants