Fix hang in BuildKite CI #2577
Merged
Fix hang in BuildKite CI #2577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pipeline looks good to me. I Since this is an upstream bug that will presumably be fixed, I would just drop the option for now and perhaps add an issue to track it, since I assume that this change has a negative effect on the CI runtime and is worth reinstating at some point. |
|
But what about the multithreading tests? How is that testing the thread safety? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that due to the bug documented at JuliaLang/julia#56458, the buildkite CI is hanging indefinitely causing the tests to fail.
This seems to be triggered by the use of the
--threads=autoflag.This merge request simply removes the flag for now, since a fix does not yet seem to be available.
https://github.com/JuliaCI/julia-test-buildkite-plugin/blob/main/hooks/command does not seem to support adding the flag at the
julia --threads=autoinvocation level, where it would again be permitted.