Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store grad/hess in state for Optim.jl #716

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

sethaxen
Copy link
Contributor

@sethaxen sethaxen commented Mar 16, 2024

The gradient and hessian when optimizing with Optim.jl were never added to the OptimizationState even when available. This PR adds them whenever available.

Checklist

  • Appropriate tests were added
  • The new feature was added in a way that does not break public API
  • New documentation related to the new feature was added
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 11.96%. Comparing base (d4f90fd) to head (0a417ea).
Report is 17 commits behind head on master.

Files Patch % Lines
lib/OptimizationOptimJL/src/OptimizationOptimJL.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #716       +/-   ##
===========================================
- Coverage   40.84%   11.96%   -28.88%     
===========================================
  Files          31       21       -10     
  Lines        2522     1438     -1084     
===========================================
- Hits         1030      172      -858     
+ Misses       1492     1266      -226     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vaibhavdixit02 Vaibhavdixit02 merged commit 7e115c9 into SciML:master Mar 16, 2024
37 of 43 checks passed
@sethaxen sethaxen deleted the optimjl_state_grad_hess branch March 16, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants