Some NLopt and MOI updates #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che` Required for MOI to work with Float32s
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
=======================================
Coverage 10.46% 10.47%
=======================================
Files 40 40
Lines 2322 2320 -2
=======================================
Hits 243 243
+ Misses 2079 2077 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This isn't sufficient, the C wrappers of other optimizers are hardcoded to give out Float64s so we can't make this handling completely automatic. The loss function would need to do a Float32 conversion despite this. But this is probably good to have even otherwise so merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.