Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try Enzyme 0.11.2 #561

Merged
merged 3 commits into from
Jul 2, 2023
Merged

Try Enzyme 0.11.2 #561

merged 3 commits into from
Jul 2, 2023

Conversation

Vaibhavdixit02
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #561 (290cdb4) into master (8682f9c) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 290cdb4 differs from pull request most recent head 2e30841. Consider uploading reports for the commit 2e30841 to get more accurate results

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
+ Coverage   10.46%   10.50%   +0.03%     
==========================================
  Files          40       40              
  Lines        2322     2323       +1     
==========================================
+ Hits          243      244       +1     
  Misses       2079     2079              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -33,7 +33,7 @@ jobs:
- OptimizationPolyalgorithms
version:
- '1'
- '1.6'
- '1.8'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisRackauckas are you okay with dropping 1.6 testing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we still support LTS. Why would it be dropped?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there was some movement towards dropping 1.6 from CI.. doesn't really matter here so no worries

@Vaibhavdixit02 Vaibhavdixit02 merged commit 7e3f178 into master Jul 2, 2023
39 of 41 checks passed
@Vaibhavdixit02 Vaibhavdixit02 deleted the Vaibhavdixit02-patch-3 branch July 2, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants