Sample enzyme extension #478
Draft
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does performance compare? |
|
From our lab meeting discussion earlier this morning, we decided to have an Enzyme special case for SimpleNonlinearSolve at the very least (I will add that via #458). We can see the overall performance benefits here (in the NonlinearSolve context) later, but for SimpleNonlinearSolve, I would argue we want to save every second we can, and if adding a minor maintenance burden is the way to go (especially with NonlinearSolveBase switching the default backend to Enzyme if loaded), then we should do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #476
Obviously should be reformatted and cleaned up a bit.