simplify __wrapprecs
#465
Merged
simplify __wrapprecs
#465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this will be obsoleted by #462 but that Pr is slightly breaking so it may need some more time. |
|
@avik-pal is all of the test failures known? |
|
Pretty much. We need a tag with updated enzyme releases |
|
I have marked master version as |
avik-pal
force-pushed
the
os/simplifiy-wrapprecs
branch
from
80b7b2b
to
445db18
Compare
avik-pal
reviewed
Sep 27, 2024
avik-pal
reviewed
Sep 27, 2024
|
once I merged the DI PR, it will fix the dep hell |
previously the preconditioner being set was a very complicated `IdentityOperator`. Using a regular `IdentityOperator` means that solvers that don't support one of the preconditioners won't throw warnings since they mostly know that `IdentityOperator`s aren't real.
avik-pal
force-pushed
the
os/simplifiy-wrapprecs
branch
from
57a2b2b
to
f4219af
Compare
|
Remove those imports and that should do it |
|
imports removed. |
avik-pal
reviewed
Sep 28, 2024
avik-pal
approved these changes
Sep 28, 2024
| if __hasfield(alg, Val(:precs)) | ||
| precs = alg.precs | ||
| Pl_, Pr_ = precs(A, nothing, u, ntuple(Returns(nothing), 6)...) | ||
| else | ||
| precs, Pl_, Pr_ = nothing, nothing, nothing | ||
| end | ||
| Pl, Pr = __wrapprecs(Pl_, Pr_, weight) | ||
| Pl, Pr = __wrapprecs(Pl_, Pr_, u) |
There was a problem hiding this comment.
It is creating an operator using only the length of u
There was a problem hiding this comment.
specifically, NonlinearSolve never actually used the weight variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously the preconditioner being set was a very complicated
IdentityOperator. Using a regularIdentityOperatormeans that solvers that don't support one of the preconditioners won't throw warnings since they mostly know thatIdentityOperators aren't real.