add TerminationCondition support to NewtonRaphson #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
===========================================
- Coverage 93.52% 59.90% -33.62%
===========================================
Files 7 7
Lines 649 656 +7
===========================================
- Hits 607 393 -214
- Misses 42 263 +221
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@oscardssmith the upstream PR SciML/DiffEqBase.jl#903 has been merged |
oscardssmith
force-pushed
the
add-termination-condition-control-to-newtonraphson
branch
from
b2ed52b
to
444620b
Compare
|
PR updated. |
|
Tests fail |
oscardssmith
force-pushed
the
add-termination-condition-control-to-newtonraphson
branch
2 times, most recently
from
5734827
to
a379410
Compare
oscardssmith
force-pushed
the
add-termination-condition-control-to-newtonraphson
branch
from
a379410
to
d0dcc4c
Compare
|
Supersceded by #208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and eventually all the other solvers). @ChrisRackauckas can you take a look at this to make sure I'm not doing dumb stuff here?