Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Documenter to 1 for package docs, (keep existing compat) #2265

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Documenter package from 0.27 to 0.27, 1 for package docs.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@YingboMa YingboMa merged commit a1369f3 into master Sep 16, 2023
@YingboMa YingboMa deleted the compathelper/new_version/2023-09-16-00-18-30-542-03745024484 branch September 16, 2023 02:25
@ArnoStrouwen
Copy link
Member

This should not have been merged in.
The makedocs keywords are no longer the same.

@YingboMa
Copy link
Member

Oops, sorry. Is there a quick fix?

@ArnoStrouwen
Copy link
Member

Maybe,
For some repos the upgrade is smooth:
SciML/ExponentialUtilities.jl#137
For some repos there appear to be some deeper issues:
SciML/LinearSolve.jl#371

Let us see what CI says:
#2267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants