New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix KyrlovJL remake #534

Closed

oscardssmith wants to merge 1 commit into SciML:main from oscardssmith:os/fix-KrylovJL-remake

Contributor

oscardssmith commented Aug 23, 2024

we had this args field that was never being used, but did break remake.

# before:
julia> remake(KrylovJL_GMRES(), precs=nothing).kwargs
pairs(::NamedTuple) with 1 entry:
  :args => ()
# after:
julia> remake(KrylovJL_GMRES(), precs=nothing).kwargs
Base.Pairs{Symbol, Union{}, Tuple{}, @NamedTuple{}}()

As a side-note, we should fix the default SciMLBase remake for structs with fields named both args and kwargs


          fix KyrlovJL remake

39c0748

Contributor Author

oscardssmith commented Aug 24, 2024

I think the proper fix here is actually SciML/SciMLBase.jl#769 (although it does appear that this functionality may not quite be working as intended)

oscardssmith closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet