Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various CI improvements #501

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

various CI improvements #501

wants to merge 2 commits into from

Conversation

ArnoStrouwen
Copy link
Member

No description provided.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.61%. Comparing base (64a8811) to head (7ccafb0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   62.71%   56.61%   -6.11%     
==========================================
  Files          29       29              
  Lines        2229     2222       -7     
==========================================
- Hits         1398     1258     -140     
- Misses        831      964     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArnoStrouwen
Copy link
Member Author

@thazhemadam do you know what the issue is here?
https://github.com/SciML/LinearSolve.jl/actions/runs/9061500275/job/24893374532?pr=501#step:8:36
The documentation link in the error message is not even working for me.

@ArnoStrouwen
Copy link
Member Author

@ChrisRackauckas
Copy link
Member

@fredrikekre "LoadError: mpiexec() is deprecated, use the non-do-block form" do you know the fix here?

@fredrikekre
Copy link
Contributor

diff --git a/test/hypretests.jl b/test/hypretests.jl
index c41079c1..da7e7e3a 100644
--- a/test/hypretests.jl
+++ b/test/hypretests.jl
@@ -168,7 +168,5 @@ test_interface(HYPREAlgorithm(HYPRE.PCG(comm)), Pl = HYPRE.BoomerAMG())

 # Test MPI execution
 mpitestfile = joinpath(@__DIR__, "hypretests_mpi.jl")
-mpiexec() do mpi
-    r = run(ignorestatus(`$(mpi) -n 2 $(Base.julia_cmd()) $(mpitestfile)`))
-    @test r.exitcode == 0
-end
+r = run(ignorestatus(`$(mpiexec()) -n 2 $(Base.julia_cmd()) $(mpitestfile)`))
+@test r.exitcode == 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants