extra robustness in fallbacks

SciML · Jan 20, 2022 · 4e0a46d · 4e0a46d
1 parent a84c420
commit 4e0a46d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "LinearSolve"
 uuid = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
 authors = ["SciML"]
-version = "1.8.1"
+version = "1.8.2"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

diff --git a/src/factorization.jl b/src/factorization.jl
@@ -223,12 +223,24 @@ function init_cacheval(alg::Union{QRFactorization,SVDFactorization,GenericFactor
 end
 
 # Ambiguity handling dispatch
-function init_cacheval(alg::Union{QRFactorization,SVDFactorization,GenericFactorization}, A::StridedMatrix{<:LinearAlgebra.BlasFloat}, b, u, Pl, Pr, maxiters, abstol, reltol, verbose)
+function init_cacheval(alg::Union{QRFactorization,SVDFactorization}, A::StridedMatrix{<:LinearAlgebra.BlasFloat}, b, u, Pl, Pr, maxiters, abstol, reltol, verbose)
     newA = copy(convert(AbstractMatrix,A))
     fill!(newA,true)
     do_factorization(alg, newA, b, u)
 end
 
+# Cholesky needs the posdef matrix, for GenericFactorization assume structure is needed
+function init_cacheval(alg::Union{GenericFactorization,GenericFactorization{typeof(cholesky)},GenericFactorization{typeof(cholesky!)}}, A, b, u, Pl, Pr, maxiters, abstol, reltol, verbose)
+    newA = copy(convert(AbstractMatrix,A))
+    do_factorization(alg, newA, b, u)
+end
+
+# Ambiguity handling dispatch
+function init_cacheval(alg::Union{GenericFactorization,GenericFactorization{typeof(cholesky)},GenericFactorization{typeof(cholesky!)}}, A::StridedMatrix{<:LinearAlgebra.BlasFloat}, b, u, Pl, Pr, maxiters, abstol, reltol, verbose)
+    newA = copy(convert(AbstractMatrix,A))
+    do_factorization(alg, newA, b, u)
+end
+
 ## RFLUFactorization
 
 struct RFWrapper{P,T}