fix vrj reinitialization bug #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that we have a Catalyst VRJ interface I think this is indicative that we really need to add more VRJ correctness tests.
edit: Actually I think this fixes that issue. When plotting the error in the mean over 10000 simulations I now see that the jump mean can indeed now sometimes exceed the analytical mean. |
|
If tests pass this should be good to go (and we should then make an immediate release). |
ChrisRackauckas
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the code to reset variable rate jump problems was not correctly broadcasting calls to
randexpresulting in the same samples being used for all jumps.cc: @ChrisRackauckas
Closes #320