Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest Turing.jl #259

Closed
wants to merge 1 commit into from
Closed

Conversation

jClugstor
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Update Turing to fix compatibility issues.

@jClugstor
Copy link
Member Author

Tests, pass, but CodeCov doesn't run. I think that's expected because of the CodeCov changes happening?

@ChrisRackauckas
Copy link
Member

datafit tests don't pass?

@jClugstor
Copy link
Member Author

I think they don't run if the Core tests don't completely pass. Since the codecov test didn't pass, the datafit tests never actually ran.

@jClugstor
Copy link
Member Author

Should I just get rid of codecov in the CI?

@ChrisRackauckas
Copy link
Member

It should already be disabled.

@jClugstor
Copy link
Member Author

Ok so the datafit tests ran, but they took so long that it canceled out?
Hmm...

@ChrisRackauckas
Copy link
Member

Is someething like the iteration limit not being respected?

@jClugstor
Copy link
Member Author

The tests are getting dt under epsilon and hitting maxiters now, which I can confirm doesn't happen with Turing 0.30. There was just a Turing patch, I'll try that.

@jClugstor jClugstor closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants