feat: move to v4 #233
Merged
feat: move to v4 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
avik-pal
commented
Sep 26, 2024
•
avik-pal
commented
- Fixes ManifoldProjection to use the actual formulation from Hairer 3
- Note that this is a breaking change (removing NonlinearSolve, users need to load it manually). Currently the version is kept as 3.10 since SciMLSensitivity has a dep on this causing a circular test dep, so can't test with v4.
- Also updates GeneralDomain as a consequence
- Removes unused deps
avik-pal
commented
Sep 26, 2024
| @@ -33,30 +20,34 @@ properties. | |||
|
|
|||
| ## Arguments | |||
|
|
|||
| - `g`: The residual function for the manifold. | |||
There was a problem hiding this comment.
Similar to how our other packages work, I am making manifold st the IIP/OOP needs to align with the ODE problem
avik-pal
commented
Sep 26, 2024
| [NonlinearSolve.jl](https://docs.sciml.ai/NonlinearSolve/stable/basics/solve/). | ||
| [NonlinearSolve.jl](https://docs.sciml.ai/NonlinearSolve/stable/basics/solve/) if | ||
| `nlsolve` is not `missing`. | ||
| - `autodiff`: The autodifferentiation algorithm to use to compute the Jacobian if |
There was a problem hiding this comment.
making this mandatory for the time being. Once NonlinearSolveBase is released, we can reconsider that.
|
Needs SciML/LinearSolve.jl#543 before we can test this |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@ChrisRackauckas the runs pass. I am bumping the version to 4. This + SciML/SciMLSensitivity.jl#1124 will drop one of the big deps in SciMLSensitivity |
ChrisRackauckas
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.