Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
@yebai pointed out to me that
safe_mode
might be better calleddebug_mode
-- he feels (and I agree) that "safe mode" sounds like something you want to have on, while "debug mode" sounds like something you only want to have on when a problem arises.Unfortunately we've effectively committed to
safe_mode
already in this package -- in order to properly change over todebug_mode
we'd have to rename thesafe_mode
field of theAutoTapir
type. This would be a breaking change, so it's not something that we can do right now.Instead, I've improved the docstring to provide a bit more context, and make it a bit clearer what the purpose of the mode is.