Skip to content

fix: use titlecase for better dataset table headers representation #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Jun 5, 2025

Description

Use the shared TitleCasePipe to improve dataset table headers by defaulting to title case when no custom header is provided

Motivation

Dataset table headers were just plain property names

Fixes:

  • Dataset table headers

Changes:

  • Import and inject TitleCasePipe into DatasetTableComponent
  • Transform column names to title case for table headers by default
  • Register TitleCasePipe in DatasetsModule providers

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Use the shared TitleCasePipe to improve dataset table headers by defaulting to title case when no custom header is provided

Enhancements:

  • Import and inject TitleCasePipe into DatasetTableComponent
  • Transform column names to title case for table headers by default
  • Register TitleCasePipe in DatasetsModule providers

Tests:

  • Add TitleCasePipe to the test bed configuration for DatasetTableComponent

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martin-trajanovski - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant