feat: mock sfera communication and add example JP and SP #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mghilardelli
commented
Oct 24, 2024
|
|
||
| var tid = TrainIdentification.fromString(elements[length - 2], elements[length - 3]); | ||
|
|
||
| return new RequestContext(tid, new ClientId(UUID.fromString(elements[length - 1])), incomingMessageId, Optional.empty()); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mghilardelli
commented
Oct 24, 2024
| import java.util.UUID; | ||
| import lombok.NonNull; | ||
|
|
||
| public record ClientId(@NonNull UUID value) implements Comparable<ClientId> { |
There was a problem hiding this comment.
- value: String
mghilardelli
commented
Oct 24, 2024
| import java.util.UUID; | ||
| import lombok.NonNull; | ||
|
|
||
| public record RequestContext(@NonNull TrainIdentification tid, @NonNull ClientId clientId, @NonNull Optional<UUID> incomingMessageId, @NonNull Optional<String> customPrefix) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
rawi-coding
approved these changes
Oct 25, 2024
| public static TrainIdentification fromString(String tid, String companyCode) { | ||
| var matcher = TID_PATTERN.matcher(tid); | ||
| if (matcher.matches()) { | ||
| var operationalNumber = matcher.group(2); |
There was a problem hiding this comment.
nitpick: you could use final var generally in your code. Just a nitpick, no need to change it now.
This was referenced Oct 24, 2024
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.