chore(docs): add attribution for contributors #2030
Conversation
|
JoCa96
force-pushed
the
chore-add-attributions
branch
from
7252b2a
to
cfa416e
Compare
|
@larsrickert Was there a specific reason why we didn't use all the team components? |
JoCa96
changed the title
| @@ -18,6 +18,7 @@ type Story = StoryObj<typeof OnyxHomePage>; | |||
| export const Default = { | |||
| args: { | |||
| data: { | |||
| contributors: [], | |||
| VPTeamPageSection | ||
| } from 'vitepress/theme' | ||
|
|
||
| const shuffleArray = (array) => |
There was a problem hiding this comment.
I get your intention with shuffeling but imho this is confusing. What do you think about ordering the core team by title and the contributors by number/size of contributions
| }, | ||
| { | ||
| avatar: 'https://www.github.com/JoCa96.png', | ||
| login: "flubnau", |
There was a problem hiding this comment.
Flo is not shown currently, propably because he hasn't contributed to GitHub yet.
But we still want to show him, right?
| name: 'Jannick Keller', | ||
| core: true, |
There was a problem hiding this comment.
Since you are the "Engineering Lead", would it be more unified if Jannick is the "Design Lead" instead of "Lead Designer"?
In my opinion, the page looks a little weird with all those components. Would prefer personally to use regular h1 headline and description. I guess these components are mainly intended to be used on the home page to fit its look. We could also think about moving the team + contributors to the home page |
| <VPTeamPageSection> | ||
| <template #title>Thank you to all contributors 🙏</template> | ||
| <template #members> | ||
| <VPTeamMembers size="small" :members="shuffleArray(contributors)" /> |
There was a problem hiding this comment.
I am not sure how this will scale in the future if we might have > 50 contributors since the page will get very large then...
VPTeamPagecomponents