Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image function #89

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Image function #89

merged 2 commits into from
Nov 25, 2020

Conversation

lawruble13
Copy link
Contributor

Image function added, no docs or tests as of yet. Caching is done by name and by size. DO NOT attempt to draw images with a size that varies over time, this will consume a lot of memory and be extremely slow.

@lawruble13 lawruble13 linked an issue Nov 25, 2020 that may be closed by this pull request
9 tasks
Copy link
Member

@AlphaRLee AlphaRLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Liam's segment approved, waiting on reviewer to check over the unit test I added

@AlphaRLee
Copy link
Member

Doing a force merge because slides team would like to have access to this (and I doubt my unit tests broke anything)

@AlphaRLee AlphaRLee merged commit fc91556 into Schulich-Ignite:dev Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add image uploads
2 participants