Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image uploads #78

Open
4 of 9 tasks
AlphaRLee opened this issue Nov 17, 2020 · 0 comments · Fixed by #89
Open
4 of 9 tasks

Add image uploads #78

AlphaRLee opened this issue Nov 17, 2020 · 0 comments · Fixed by #89
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@AlphaRLee
Copy link
Member

AlphaRLee commented Nov 17, 2020

Students enjoy using images for characters in their games

AC:

  • Add an image("file_name.png", x, y, width, height) function
  • Draw the image at the given x and y and selected width and height
  • If width and height are negative, invert the picture and draw to the left/above the X/Y respectively
  • Must work with extensions being case-insensitive (e.g. works with .PnG)
  • Restrict image() to only accept .png, .jpg, .jpeg .svg - maybe there's a way to get the HTML image types on the input
    • Look into adding .gif and/or .webp, not hard requirement
  • Unit tests
    • Test bad file types and bad file names
  • Docs
@AlphaRLee AlphaRLee added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 17, 2020
@AlphaRLee AlphaRLee added this to the Week 7 milestone Nov 17, 2020
@lawruble13 lawruble13 self-assigned this Nov 24, 2020
@lawruble13 lawruble13 linked a pull request Nov 25, 2020 that will close this issue
@AlphaRLee AlphaRLee added the good first issue Good for newcomers label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants