Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MembershipTemplates are displayed in products #58

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

LobeTia
Copy link
Contributor

@LobeTia LobeTia commented Apr 18, 2024

πŸ”— Linked issue

Resolves #56

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Link Membership and MembershipTemplates and tracks the used Membership in the database, MembershipsTemplates are also display in the member portal and in the SignUp form

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@LobeTia LobeTia changed the title Progress MembershipTemplates are displayed in products Apr 18, 2024
package.json Outdated
@@ -57,7 +61,7 @@
"devDependencies": {
"@types/eslint": "^8.56.2",
"@types/lodash": "^4.17.0",
"@types/node": "^20.11.20",
"@types/node": "^20.12.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using the node 20.12.7 version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using node 20 lts (iron)
I aligned the corresponding .nvm file to always point to the latest lts version and updated package semver to fetch the latest version, please note that types and node are now always aligned

TheJoin95
TheJoin95 previously approved these changes Apr 18, 2024
Copy link
Member

@TheJoin95 TheJoin95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's time to prioritise the i18n issue #9

Base automatically changed from feat/27/admin-can-create-membership to main April 28, 2024 21:33
@LobeTia LobeTia dismissed TheJoin95’s stale review April 28, 2024 21:33

The base branch was changed.

…mplate-support

# Conflicts:
#	src/app/actions/createMembership.ts
#	src/app/members/@authenticated/page.tsx
#	src/app/signup/page.tsx
#	src/components/molecules/membershipTemplateCard.tsx
Created seeding utility to avoid code-repetition
@LobeTia LobeTia merged commit d9969bc into main Sep 30, 2024
@LobeTia LobeTia deleted the feat/56/membership-template-support branch September 30, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MembershipTemplate support across portals
2 participants