Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Localization #65

Open
Schlaubischlump opened this issue Jan 9, 2021 · 29 comments
Open

[Feature] Localization #65

Schlaubischlump opened this issue Jan 9, 2021 · 29 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Schlaubischlump
Copy link
Owner

Schlaubischlump commented Jan 9, 2021 •
edited
Loading

To update the main application interface the discussion moved here.

To update the help menu entry for LocationSimulator look here.
@Schlaubischlump Schlaubischlump added the enhancement New feature or request label Jan 9, 2021
@bailaowai
Copy link

bailaowai commented Jan 9, 2021 via email

@Schlaubischlump
Copy link
Owner Author

At the moment only english is available. Since I can't speak chinese, somebody else has to add the translation. I can upload a list with all strings to translate. This might make it easier to contribute a translation.

@bailaowai
Copy link

bailaowai commented Jan 9, 2021 via email

@Schlaubischlump
Copy link
Owner Author

Technically there are already uploaded, just a little bit hidden in the project structure. I'll inform you when I restructured the strings file.

@bailaowai
Copy link

bailaowai commented Jan 9, 2021 via email

@Schlaubischlump
Copy link
Owner Author

Which languages would you like to contribute ? I need to create the necessary folder structures first

@bailaowai
Copy link

bailaowai commented Jan 10, 2021 via email

@Schlaubischlump
Copy link
Owner Author

Schlaubischlump commented Jan 10, 2021 •
edited
Loading

I restructured the localization files and uploaded a german translation as an example. The german translation can be found here and the original english translation here. Most likely I added a bunch of spelling mistakes, because it's pretty late in Germany and I'm getting tired. If you find any in the English translation let me know! It's quit a lot of work to localize the project, since you have to translate the default apple menu items as well, because there is no automatic way to do this. I can totally understand if you don't have the time to translate the project. I added the spanisch translation template here. Just replace the right side of the text with the correct translation. If you know how to open a pull request, it would be create if you do so, after you are finished. If not, just upload the file and I'll add it to the project.

@Schlaubischlump Schlaubischlump added the help wanted Extra attention is needed label Jan 10, 2021
@bailaowai
Copy link

bailaowai commented Jan 10, 2021 via email

@Schlaubischlump
Copy link
Owner Author

Schlaubischlump commented Jan 10, 2021 •
edited
Loading

I was able to automatically translate some of the default menubar entries thanks to a github project I found. I updated the Spanish file. I hope that helps a little bit!

Here is a list with all remaining keys to translate:
ReaminingKeys.txt

@bailaowai
Copy link

bailaowai commented Jan 13, 2021 via email

@bailaowai
Copy link

bailaowai commented Jan 14, 2021 via email

@Schlaubischlump
Copy link
Owner Author

Thank you for you contribution ! Unfortunately I'm unable to see any attachment? Did something went wrong during the upload ?

@bailaowai
Copy link

bailaowai commented Jan 14, 2021 via email

@Schlaubischlump
Copy link
Owner Author

I uploaded the templates. Can you send me or upload the word file ?

@bailaowai
Copy link

bailaowai commented Jan 14, 2021 via email

@Schlaubischlump
Copy link
Owner Author

Which mail address did you use ? You can just drag & drop the file inside you github comment to upload it

@bailaowai
Copy link

bailaowai commented Jan 14, 2021 via email

@Schlaubischlump
Copy link
Owner Author

Thank you ! This is working, as well. You can just attach a word file to the github comment, the next time, then you don't have to copy and paste the content.

I'll add the translation and upload the changes

@bailaowai
Copy link

bailaowai commented Jan 14, 2021 via email

@bailaowai
Copy link

bailaowai commented Jan 19, 2021 via email

@bailaowai
Copy link

bailaowai commented Jan 19, 2021 via email

@Schlaubischlump
Copy link
Owner Author

Schlaubischlump commented Jan 19, 2021 •
edited
Loading

Thank you so much for the translation! The github comment seems to mess up the formatting.

I got the e-mail. Thank you again, for your time and effort ! I'll integrate the translation and upload a new version with the translation included in the next days.

@bailaowai
Copy link

bailaowai commented Feb 2, 2021 via email

@Schlaubischlump
Copy link
Owner Author

I haven't updated the release build on homebrew yet. You can download this version and just replace you existing LocationSimulator.app with the downloaded one. If you start the app, it should automatically pick up your current language settings and translate the interface.

@Schlaubischlump Schlaubischlump added the good first issue Good for newcomers label Mar 15, 2021
@Schlaubischlump Schlaubischlump changed the title Localization [Feature] Localization Jul 6, 2021
@Rithari
Copy link
Contributor

Rithari commented Feb 10, 2022

Hello,

I'd be happy to help with the translation to Italian.
Feel free to create the folder structure for it and I will submit a PR accordingly.

@Schlaubischlump
Copy link
Owner Author

Hi @Rithari,

thank you for the offer to translate the project to Italian. I really appreciate it :) I just uploaded the Italian template. Some of the entries are already auto translated, based on a different github project I modified for my needs. It might be a good idea to check them as well.

@Schlaubischlump
Copy link
Owner Author

@bailaowai, @devmaximilian, @Rithari I added a couple of new features which need localisation. It would be great, if you find the time to update the localisation. I found it tool which makes things a little bit easier. You can download it here: https://github.com/igorkulman/iOSLocalizationEditor/releases/tag/v2.9

To use the tool do the following:

  1. Download or clone LocationSimulators source code.
  2. Start LocalizationEditor and click on the folder icon
  3. Choose the LocationSimulator/LocationSimulator/Localization folder you just download with the LocationSimulators source code
  4. You'll get a list will all strings to localize. The missing strings are highlighted with a red border.
  5. If you are finished press cmd + s on your keyboard (Somehow there is no menu item)
  6. You can now copy the file localization file from LocationSimulator/LocationSimulator/Localization and upload it to github as a comment (just drag and drop the file) or create a pull request if you now how to do this

@devmaximilian devmaximilian mentioned this issue Mar 18, 2022
Merged
@Schlaubischlump Schlaubischlump pinned this issue Apr 30, 2022
@Black-Dragon-Spirit
Copy link

nl.lproj.zip
Partial translated

@Schlaubischlump Schlaubischlump mentioned this issue Oct 5, 2022
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Schlaubischlump @Rithari @bailaowai @Black-Dragon-Spirit