Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format lighthouse #221

Merged
merged 18 commits into from
May 13, 2024
Merged

Format lighthouse #221

merged 18 commits into from
May 13, 2024

Conversation

Scc33
Copy link
Owner

@Scc33 Scc33 commented May 7, 2024

Describe your changes

  • Add commenting of lighthouse results
  • Add commenting of test results

Issue ticket number and link

Close #219

Checklist before requesting a review

  • I have performed a self-review of my code
  • The pipeline is passing

Copy link

github-actions bot commented May 7, 2024

Unit Test Coverage Report

Unit Test Report

Tests Skipped Failures Errors Time
16 0 💤 0 ❌ 0 🔥 3.124s ⏱️

@Scc33
Copy link
Owner Author

Scc33 commented May 7, 2024

Added unit test commenting from https://github.com/MishaKav/jest-coverage-comment

Copy link

github-actions bot commented May 7, 2024

Lighthouse Results

Performance Accessibility Best Practices SEO
🔴 73 🟢 100 🟢 100 🟢 100

@Scc33 Scc33 marked this pull request as ready for review May 7, 2024 23:09
@Scc33 Scc33 merged commit 146c05d into master May 13, 2024
4 checks passed
@Scc33 Scc33 deleted the formatLighthouse branch May 13, 2024 15:37
@Scc33
Copy link
Owner Author

Scc33 commented May 13, 2024

Can be improved later with removing dependency on outdated functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Format and comment lighthouse results
1 participant