Update footer and header with portfolio

Scc33 · Jul 2, 2024 · fe25967 · fe25967
1 parent 0ed21c2
commit fe25967
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 4 deletions.
diff --git a/src/components/Footer/Footer.test.ts b/src/components/Footer/Footer.test.ts
@@ -26,6 +26,16 @@ describe("footer Component", () => {
     expect(link.getAttribute("target")).toBe("_blank");
   });
 
+  it("has correct link to Portfolio", () => {
+    expect.assertions(2);
+    const { container } = render(Footer);
+    const link = container.querySelector(
+      'a[href="https://portfolio.seancoughlin.me"]'
+    );
+    expect(link).toBeTruthy();
+    expect(link.getAttribute("target")).toBe("_blank");
+  });
+
   it("has correct link to LinkedIn", () => {
     expect.assertions(2);
     const { container } = render(Footer);

diff --git a/src/components/Header/Header.test.ts b/src/components/Header/Header.test.ts
@@ -15,15 +15,16 @@ describe("header Component", () => {
   });
 
   it("renders all header text with correct text", () => {
-    expect.assertions(3);
+    expect.assertions(4);
     const { getByText } = render(Header, { y: 0 });
     expect(getByText("LinkedIn")).toBeVisible();
     expect(getByText("GitHub")).toBeVisible();
+    expect(getByText("Portfolio")).toBeVisible();
     expect(getByText("Blog")).toBeVisible();
   });
 
   it("renders all header text with correct links", () => {
-    expect.assertions(3);
+    expect.assertions(4);
     const { getByText } = render(Header, { y: 0 });
     expect(getByText("LinkedIn").closest("a")).toHaveAttribute(
       "href",
@@ -33,6 +34,10 @@ describe("header Component", () => {
       "href",
       "https://github.com/Scc33"
     );
+    expect(getByText("Portfolio").closest("a")).toHaveAttribute(
+      "href",
+      "https://portfolio.seancoughlin.me"
+    );
     expect(getByText("Blog").closest("a")).toHaveAttribute(
       "href",
       "https://blog.seancoughlin.me"

diff --git a/src/data/Links.ts b/src/data/Links.ts
@@ -6,13 +6,17 @@ interface Links {
 const links: Links[] = [
   { name: "Email", url: "mailto:[email protected]" },
   {
-    name: " LinkedIn",
+    name: "LinkedIn",
     url: "https://www.linkedin.com/in/sean-m-coughlin"
   },
   {
-    name: " GitHub",
+    name: "GitHub",
     url: "https://github.com/Scc33"
   },
+  {
+    name: "Portfolio",
+    url: "https://portfolio.seancoughlin.me"
+  },
   {
     name: "Blog",
     url: "https://blog.seancoughlin.me"

diff --git a/tests/homepage.test.js b/tests/homepage.test.js
@@ -28,6 +28,9 @@ test.describe("home page", () => {
     await expect(
       page.getByRole("banner").getByRole("link", { name: "GitHub" })
     ).toBeVisible();
+    await expect(
+      page.getByRole("banner").getByRole("link", { name: "Portfolio" })
+    ).toBeVisible();
     await expect(
       page.getByRole("banner").getByRole("link", { name: "Blog" })
     ).toBeVisible();
@@ -57,6 +60,9 @@ test.describe("home page", () => {
     await expect(
       page.getByRole("contentinfo").getByRole("link", { name: "GitHub" })
     ).toBeVisible();
+    await expect(
+      page.getByRole("contentinfo").getByRole("link", { name: "Portfolio" })
+    ).toBeVisible();
     await expect(
       page.getByRole("contentinfo").getByRole("link", { name: "Blog" })
     ).toBeVisible();