Branch test #1
Merged
Branch test #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhuangg
reviewed
Apr 8, 2018
| </head> | ||
|
|
||
| <body> | ||
| <div id="MapView"></div> |
There was a problem hiding this comment.
This tag should be in the MapView.js file on line 19
dhuangg
reviewed
Apr 8, 2018
src/components/MapView/mapTest.html
Outdated
| <link rel="stylesheet" href="https://unpkg.com/[email protected]/dist/leaflet.css"/> | ||
|
|
||
| <style> | ||
| #MapView{ |
There was a problem hiding this comment.
this is CSS (styling for the component), move this to MapView.css (should be in the same MapView directory)
dhuangg
reviewed
Apr 8, 2018
| <div id="MapView"></div> | ||
| <script src="https://unpkg.com/[email protected]/dist/leaflet.js"></script> | ||
|
|
||
| <script> |
There was a problem hiding this comment.
Any javascript you use should be in MapView.js for consistency. you can add this on MapView.js after line 16
dhuangg
requested changes
Apr 8, 2018
…op up the 'place_people_person_full_name' will display, if the value is 'null' no item will pop up. Keep in mind that in the mapTest.html file I have only used a subset of the geoJson data because using the whole thing makes the IDE lag significantly. The feature is completely ready to be implemented we can go back to the full data set.
dhuangg
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.