Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STORY-648] feat: raise DB user passwords minimum length to 24 #1077

Merged
merged 6 commits into from
Sep 17, 2024
Merged

[STORY-648] feat: raise DB user passwords minimum length to 24 #1077

merged 6 commits into from
Sep 17, 2024

Conversation

sc-david-voisin
Copy link
Contributor

@sc-david-voisin sc-david-voisin commented Sep 16, 2024 •
edited
Loading

DB user passwords length must be between 24 to 64.

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

STORY-648

@notion-workspace Notion Workspace
Copy link

Upgrade our password strength policy for databasesf

@sc-david-voisin sc-david-voisin marked this pull request as draft September 16, 2024 13:47
@sc-david-voisin sc-david-voisin marked this pull request as ready for review September 16, 2024 15:18
curzolapierre
curzolapierre reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@curzolapierre curzolapierre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question/comment otherwise LGTM

db/users/utils_test.go Outdated Show resolved Hide resolved
@sc-david-voisin sc-david-voisin self-assigned this Sep 17, 2024
@sc-david-voisin sc-david-voisin merged commit bb65243 into master Sep 17, 2024
7 checks passed
@sc-david-voisin sc-david-voisin deleted the feat/database-dashboard/659/strengthen_passwords branch September 17, 2024 12:07
@BrewTestBot BrewTestBot mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curzolapierre curzolapierre curzolapierre approved these changes

@EtienneM EtienneM Awaiting requested review from EtienneM

Assignees

@sc-david-voisin sc-david-voisin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc-david-voisin @curzolapierre