feat(region): more debug logs #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneM
commented
Sep 18, 2023
Comment on lines
+55
to
+57
| if err != nil { | ||
| debug.Printf("[Regions] Fail to open the cache: %v\n", err) | ||
| } else { |
There was a problem hiding this comment.
We are more used to check err != nil in Go. So I'm refactoring to use this pattern here.
There was a problem hiding this comment.
Question: Why don't we use defer fd.Close()?
It seems more secure IMO.
There was a problem hiding this comment.
I don't know. Maybe it's useless in this case to wait longer before closing the file descriptor: we decode its content then immediately close it.
Comment on lines
+108
to
111
| if err != nil { | ||
| debug.Printf("[Regions] Failed to save the cache: %v\n", err) | ||
| return regionsCache, nil | ||
| } |
There was a problem hiding this comment.
We are more used to check err != nil in Go. So I'm refactoring to use this pattern here.
EtienneM
requested review from
brandon-welsch,
curzolapierre and
ipfaze
and removed request for
curzolapierre
ipfaze
requested changes
Sep 22, 2023
Comment on lines
+55
to
+57
| if err != nil { | ||
| debug.Printf("[Regions] Fail to open the cache: %v\n", err) | ||
| } else { |
There was a problem hiding this comment.
Question: Why don't we use defer fd.Close()?
It seems more secure IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #866
This may help debug #809.