fix(install): for MacOS compatibility, remove usage of long parameter for cut and tr #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneM
approved these changes
Sep 7, 2023
| @@ -110,7 +118,7 @@ main() { | |||
| tmpdir=$(mktemp -d /tmp/scalingo_cli_XXX) | |||
| trap "clean_install ${tmpdir}" EXIT | |||
|
|
|||
| version=$(curl --silent https://cli-dl.scalingo.com/version | tr --delete ' \t\n') | |||
| version=$(curl --silent https://cli-dl.scalingo.com/version | tr -d ' \t\n') | |||
There was a problem hiding this comment.
question(non blocking): Maybe add a comment everywhere you use short option to explain the reason? As the Scalingo good practice is to use long options, we will maybe be tempted to update these options again in the future.
curzolapierre
force-pushed
the
fix/1001/fix_install_script_for_mac
branch
from
84e228d
to
86597d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- [ ] Add a changelog entry in the section "To Be Released" of CHANGELOG.mdFixes #1001