Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Contribution Links #166

Merged
merged 8 commits into from
Aug 19, 2020
Merged

Added Contribution Links #166

merged 8 commits into from
Aug 19, 2020

Conversation

Easybuoy
Copy link
Member

What does this PR do?

  • Adds the contribution items of Slack and Github links to the footer of the site

Description of Task to be completed?

  • Not sure on this one but I believe it only needs merging

How should this be manually tested?

  • run the site locally and visually check the footer is OK. Run react tests with the test:all script.

What are the relevant Trello Card stories? Trello Card Item

Pull Request Type (check one)

  • Feature
  • Bug Fixes
  • Chore

Developer Checklist

  • New code has been scanned for ESlint issues
  • I have tested my code locally
  • I made sure that there are no other pull requests that solve for this issue
  • My code follows the same structure within the guidelines

Screenshots (if appropriate)

image

@Easybuoy Easybuoy requested a review from a team August 17, 2020 16:03
@Easybuoy Easybuoy requested a review from samakintunde August 18, 2020 09:06
Copy link
Member

@samakintunde samakintunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Great job!

@hybridcattt hybridcattt requested a review from vinny2020 August 19, 2020 21:05
@kndri kndri merged commit 2275d05 into master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants