Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fetching BOLT12 invoices from an offer #82

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented Nov 6, 2024

This PR adds support for the POST /lightning/{currency}/bolt12/fetch endpoint, where the only currency supported for now is BTC.

Copy link
Collaborator

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also plan on implementing the validation that the fetched invoice does belong to the offer in boltz-rust?

}
);

let end_point = "lightning/BTC/bolt12/fetch".to_string();
Copy link
Collaborator

@michael1011 michael1011 Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding BTC as symbol is fine

@i5hi
Copy link
Collaborator

i5hi commented Nov 7, 2024

I investigated the test failure; some of the flags we are using are deprecated &| nightly features. Not an issue with this PR; I will merge and update CI files.

Thanks @ok300

@i5hi i5hi merged commit 19e0107 into SatoshiPortal:trunk Nov 7, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants