Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Fix versions handling for 6.10 and beyond. #242

Closed
wants to merge 1 commit into from

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jun 4, 2021

Originally the version handling was not supposed to work beyond 6.9, it used only the first three characters obtained from the version of the satellite package and casted it to float for comparsion. This way the 6.10 version was considered as 6.1 and some tests targeted to run on versions 6.7 and lower were running (and failing) on 6.10 too.

Fixes point 2. of issue #241

Test result against Sat 6.10:

(venv) [vsedmik@localhost testfm]$ pytest -sv --ansible-host-pattern server --ansible-user=root --ansible-inventory testfm/inventory tests/test_backup.py::test_positive_backup_stopped_dynflowd tests/test_backup.py::test_positive_backup_stopped_foreman_tasks tests/test_packages.py::test_positive_lock_package_versions
=================== test session starts ===================
platform linux -- Python 3.9.5, pytest-3.6.1, py-1.10.0, pluggy-0.6.0 -- /home/vsedmik/PycharmProjects/testfm/venv/bin/python
cachedir: .pytest_cache
ansible: 2.9.20
rootdir: /home/vsedmik/PycharmProjects/testfm, inifile:
plugins: ansible-2.2.3
collected 3 items                                                                                                                                                                                                                         

tests/test_backup.py::test_positive_backup_stopped_dynflowd SKIPPED
tests/test_backup.py::test_positive_backup_stopped_foreman_tasks SKIPPED
tests/test_packages.py::test_positive_lock_package_versions Loading callback plugin unnamed of type old, v1.0 from /home/vsedmik/PycharmProjects/testfm/venv/lib64/python3.9/site-packages/pytest_ansible/module_dispatcher/v28.py
...
=================== 1 passed, 2 skipped in 1082.35 seconds ===================

@vercel
Copy link

vercel bot commented Jun 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/jyejare/testfm/CoYxeiK6hQZPN7AvBoHcWYYaMVEa
✅ Preview: https://testfm-git-fork-vsedmik-fix-versioning-jyejare.vercel.app

@Gauravtalreja1
Copy link
Collaborator

@vsedmik any updates on this?

did you manage to try versioning with either settings.robottelo.satellite_version or settings.server.version.release ?

@vsedmik
Copy link
Contributor Author

vsedmik commented Jun 29, 2021

@Gauravtalreja1, sorry but not yet, I've prioritized the backup/restore which has bigger impact on the product. If you have free bandwidth, feel free to take it.

@vsedmik
Copy link
Contributor Author

vsedmik commented Oct 1, 2021

Closing as outdated.

@vsedmik vsedmik closed this Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants