This repository has been archived by the owner on Aug 22, 2023. It is now read-only.
Fix versions handling for 6.10 and beyond. #242
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the version handling was not supposed to work beyond 6.9, it used only the first three characters obtained from the version of the satellite package and casted it to float for comparsion. This way the 6.10 version was considered as 6.1 and some tests targeted to run on versions 6.7 and lower were running (and failing) on 6.10 too.
Fixes point 2. of issue #241
Test result against Sat 6.10: