Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rhsc9 repo to constants to fix tests using sat.REPOS #17274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jan 8, 2025

Problem Statement

Couple of tests (like test_podman_push) are failing since 6.16+ SATs operate on RHEL9 but the sat.REPOS mixins fails here to get the related repos from constants.

Solution

Update the constants with rhsc9 repo.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_docker.py -k podman_push

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.16.z Introduced in or relating directly to Satellite 6.16 labels Jan 8, 2025
@vsedmik vsedmik requested a review from a team January 8, 2025 10:55
@vsedmik vsedmik self-assigned this Jan 8, 2025
@vsedmik vsedmik requested a review from a team as a code owner January 8, 2025 10:55
@vsedmik
Copy link
Contributor Author

vsedmik commented Jan 8, 2025

trigger: test-robottelo
pytest: tests/foreman/api/test_docker.py -k podman_push

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9781
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_docker.py -k podman_push --external-logging
Test Result : ========== 1 passed, 46 deselected, 55 warnings in 730.98s (0:12:10) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 8, 2025
@@ -394,6 +395,15 @@
'distro': 'rhel7',
'key': 'rhs',
},
'rhsc7': {
'id': 'rhel-7-server-satellite-capsule-6.11-rpms',
'name': ('Red Hat Satellite Capsule 6.11 for RHEL 7 Server RPMs x86_64'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious to know, why do we need old 6.11 repo? and can't we bump it to latest 6.16? same for rhsc8..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I just moved it so the rhscX repos are sorted from 7 to 9. Haven't touched the values of rhsc7.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I understand but I feel we can leverage the opportunity to bump this versions as well based on its usage in the repo

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @Gauravtalreja1 brings up a good point for the 6.11 repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants