-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rhsc9 repo to constants to fix tests using sat.REPOS #17274
base: master
Are you sure you want to change the base?
Conversation
trigger: test-robottelo |
PRT Result
|
@@ -394,6 +395,15 @@ | |||
'distro': 'rhel7', | |||
'key': 'rhs', | |||
}, | |||
'rhsc7': { | |||
'id': 'rhel-7-server-satellite-capsule-6.11-rpms', | |||
'name': ('Red Hat Satellite Capsule 6.11 for RHEL 7 Server RPMs x86_64'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious to know, why do we need old 6.11 repo? and can't we bump it to latest 6.16? same for rhsc8..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I just moved it so the rhscX
repos are sorted from 7 to 9. Haven't touched the values of rhsc7
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I understand but I feel we can leverage the opportunity to bump this versions as well based on its usage in the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @Gauravtalreja1 brings up a good point for the 6.11 repo
Problem Statement
Couple of tests (like
test_podman_push
) are failing since 6.16+ SATs operate on RHEL9 but thesat.REPOS
mixins fails here to get the related repos from constants.Solution
Update the constants with rhsc9 repo.
PRT test Cases example