Update target os name due to RHELC-1737

[shweta83]

Problem Statement

Bug#RHELC-1737: Incorrect target os name post conversion to RHEL

Solution

Updated assertion

Related Issues

[shweta83]

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py -k test_convert2rhel_centos_with_pre_conversion_template_check[centos8]

[Satellite-QE]

PRT Result

Build Number: 9680
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py -k test_convert2rhel_centos_with_pre_conversion_template_check[centos8] --external-logging
Test Result : ========== 1 passed, 3 deselected, 16 warnings in 1759.55s (0:29:19) ===========

[shweta83]

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

[Satellite-QE]

PRT Result

Build Number: 9681
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py --external-logging
Test Result : ============ 3 passed, 772 warnings, 1 error in 6235.11s (1:43:55) =============

[Gauravtalreja1]

It isn't good practice to modify assertion as per open issue, but when checking locally this assertion is always true, so I'd suggest to handle it in the variable instead of assertion, and I think it's best to check 'CentOS Linux' instead of just CentOS for target_os.name

Suggested change

	assert (
	"CentOS"
	if is_open('RHELC-1737')
	else target_os_name in convert2rhel_facts['conversions.target_os.name']
	)
	target_os_name = 'CentOS Linux' if is_open('RHELC-1737') else 'Red Hat'
	assert target_os_name in convert2rhel_facts['conversions.target_os.name']

[shweta83]

This is altered because of the open bug and I added a check for it. But you are right, we should not do incorrect assertions. I have skipped the assertion until bug is fixed.

[Gauravtalreja1]

no, I don't mean to skip entire assertion until bug is fixed, instead we can check if we're getting same target OS as source OS until its fixed as suggested in the target_os_name variable and not in assertion

[shweta83]

Why should we assert the incorrect target_os_version? I think it is better to skip it. We do not expect os_version to be CentOS or Oracle post conversion. Wdyt?

[Gauravtalreja1]

we've been validating this fact for a while for conversion tests, so I don't think it's good idea to skip it now, instead I'd suggest and think asserting both source_os and target_os is good addition to our conversion tests, and anyway It'll verify at least we're getting this facts after conversion

[shweta83]

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

[Satellite-QE]

PRT Result

Build Number: 9694
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py --external-logging
Test Result : ======= 2 failed, 1 passed, 718 warnings, 1 error in 4975.29s (1:22:55) ========

[Satellite-QE]

PRT Result

Build Number: 9699
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py --external-logging
Test Result : ======= 2 failed, 1 passed, 699 warnings, 1 error in 4992.45s (1:23:12) ========

[shweta83]

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

[Satellite-QE]

PRT Result

Build Number: 9713
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py --external-logging
Test Result : ======= 2 failed, 1 passed, 639 warnings, 1 error in 4411.28s (1:13:31) ========