Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rhel10 support in registration tests #17181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add rhel10 support in registration tests #17181

wants to merge 1 commit into from
+16 −18

Conversation

shweta83
Copy link
Contributor

Problem Statement

Missing support for RHEL10 for Registration and Facts

Solution

Added support of RHEL10

Related Issues

@shweta83 shweta83 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Dec 16, 2024
@shweta83 shweta83 requested a review from a team as a code owner December 16, 2024 05:59
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_fact.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9625
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_fact.py --external-logging
Test Result : ================== 2 failed, 33 warnings in 875.67s (0:14:35) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Dec 16, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9626
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_fact.py --external-logging
Test Result : ================= 27 warnings, 2 errors in 1657.99s (0:27:37) ==================

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9629
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_fact.py --external-logging
Test Result : ================= 27 warnings, 2 errors in 1532.18s (0:25:32) ==================

@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_fact.py -k test_positive_facts_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9639
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_fact.py -k test_positive_facts_end_to_end --external-logging
Test Result : ========= 2 passed, 10 deselected, 118 warnings in 1146.39s (0:19:06) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Dec 17, 2024
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_fact.py -k test_positive_facts_end_to_end

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 17, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9647
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_fact.py -k test_positive_facts_end_to_end --external-logging
Test Result : ========= 7 passed, 15 deselected, 602 warnings in 2924.00s (0:48:43) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 17, 2024
@shweta83 shweta83 force-pushed the add_rhel10_support branch 2 times, most recently from 2ed2fb4 to e99dd03 Compare December 17, 2024 13:19
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_fact.py -k test_positive_facts_end_to_end

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 17, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9649
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_fact.py -k test_positive_facts_end_to_end --external-logging
Test Result : ========= 2 passed, 10 deselected, 127 warnings in 1264.37s (0:21:04) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 17, 2024
Gauravtalreja1
Gauravtalreja1 reviewed Dec 25, 2024
View reviewed changes
tests/foreman/cli/test_fact.py
@@ -140,7 +140,7 @@ def test_positive_facts_end_to_end(
), f'Assertion failed: {fact} (expected: {expected_value}, actual: {actual_value})'


@pytest.mark.rhel_ver_list([settings.content_host.default_rhel_version])
@pytest.mark.rhel_ver_match('N-1')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, N-1 means parametrizing tests for EL9 and EL10, I don't understand why we're including so many tests for EL10, which imo could make our tests redundant, so could you please evaluate it again which tests needs to be parametrized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the updated tests are relevant for RHEL10 so I added that. I have removed rhel 10 paraameterization from couple of tests. Please re-review it.

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 27, 2024
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_fact.py -k test_positive_facts_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9715
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_fact.py -k test_positive_facts_end_to_end --external-logging
Test Result : ========= 2 passed, 10 deselected, 120 warnings in 1100.95s (0:18:20) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stejskalleos stejskalleos Awaiting requested review from stejskalleos

@Gauravtalreja1 Gauravtalreja1 Awaiting requested review from Gauravtalreja1

Assignees

@shweta83 shweta83

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shweta83 @Satellite-QE @Gauravtalreja1