Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added wait for tasks for repo creation #17171

Merged
merged 2 commits into from
Dec 26, 2024
Merged

added wait for tasks for repo creation #17171

merged 2 commits into from
Dec 26, 2024

Conversation

vijaysawant
Copy link
Contributor

Problem Statement

Few tests from tests/foreman/api/test_docker.py are failing due to pending tasks issue in repositories of cv.
Error:
"errors":["Pending tasks detected in repositories of this content view. Please wait for the tasks: - https://satellite-ip.redhat.com/foreman_tasks/tasks/207e977b-d3df-4daa-94ba-27a7b7cbdc69 before publishing."

Affected test cases:

TestDockerActivationKey::test_positive_add_docker_repo_cv
TestDockerActivationKey::test_positive_remove_docker_repo_cv
TestDockerActivationKey::test_positive_add_docker_repo_ccv
TestDockerActivationKey::test_positive_remove_docker_repo_ccv

Solution

add wait_for_tasks to wait for resource type Katello::Repository while repo creating.

Related Issues

N/A

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_docker.py::TestDockerActivationKey

@vijaysawant vijaysawant added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.16.z Introduced in or relating directly to Satellite 6.16 labels Dec 13, 2024
@vijaysawant vijaysawant requested a review from a team as a code owner December 13, 2024 12:16
@vijaysawant
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/api/test_docker.py::TestDockerActivationKey

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9616
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_docker.py::TestDockerActivationKey --external-logging
Test Result : ============ 2 failed, 2 passed, 108 warnings in 728.83s (0:12:08) =============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Dec 13, 2024
vsedmik
vsedmik reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wait for metadata generate looks good. 👍

We may need to update both, CV and LCE, together to fix the PRT to pass.

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9705
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_docker.py::TestDockerActivationKey --external-logging
Test Result : ============ 2 failed, 2 passed, 105 warnings in 681.13s (0:11:21) =============

@vijaysawant vijaysawant force-pushed the fix-for-docker-activation-key-case branch from 07aea1b to f15f8dc Compare December 24, 2024 15:29
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9706
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_docker.py::TestDockerActivationKey --external-logging
Test Result : ============ 2 failed, 2 passed, 105 warnings in 659.50s (0:10:59) =============

@vijaysawant vijaysawant force-pushed the fix-for-docker-activation-key-case branch from f15f8dc to 7adee81 Compare December 24, 2024 17:08
@vijaysawant
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/api/test_docker.py::TestDockerActivationKey

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9707
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_docker.py::TestDockerActivationKey --external-logging
Test Result : ================= 4 passed, 106 warnings in 690.33s (0:11:30) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Dec 24, 2024
@amolpati30 amolpati30 self-requested a review December 26, 2024 12:31
amolpati30
amolpati30 approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@amolpati30 amolpati30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ACK.

@amolpati30 amolpati30 merged commit ea40470 into SatelliteQE:master Dec 26, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 26, 2024
@vijaysawant @web-flow
added wait for tasks for repo creation (#17171)
30a90aa 
* added wait for tasks for repo creation

* update ak with cv and env to get rid out of error

(cherry picked from commit ea40470)
@Satellite-QE Satellite-QE mentioned this pull request Dec 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyejare jyejare jyejare approved these changes

@amolpati30 amolpati30 amolpati30 approved these changes

@vsedmik vsedmik Awaiting requested review from vsedmik

@jeremylenz jeremylenz Awaiting requested review from jeremylenz

@damoore044 damoore044 Awaiting requested review from damoore044

Assignees

@vijaysawant vijaysawant

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vijaysawant @Satellite-QE @jyejare @vsedmik @amolpati30