Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test checking needs publish banner on cv index page #17154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sambible
Copy link
Contributor

Problem Statement

Test supporting this Customer Issue: https://issues.redhat.com/browse/SAT-28271

Solution

Adds a test validating this issue+

Related Issues

Requires Airgun PR: SatelliteQE/airgun#1653

@sambible sambible requested a review from a team December 12, 2024 06:41
@sambible sambible self-assigned this Dec 12, 2024
@LadislavVasina1
Copy link
Contributor

@sambible To which branches do you want this PR to be merged?



@pytest.mark.upgrade
@pytest.mark.tier2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@pytest.mark.tier2

We don't use tier markers anymore.

Comment on lines +355 to +359
result = session.contentview_new.check_publish_banner(cv.name)
assert result
cv.publish()
result2 = session.contentview_new.check_publish_banner(cv.name)
assert not result2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
result = session.contentview_new.check_publish_banner(cv.name)
assert result
cv.publish()
result2 = session.contentview_new.check_publish_banner(cv.name)
assert not result2
assert session.contentview_new.check_publish_banner(cv.name)
cv.publish()
assert not session.contentview_new.check_publish_banner(cv.name)

4. Check the publish wizard again for the CV and verify the warning isn't visible

:expectedresults: The publish warning banner accurately reflects the status of the CV

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:Verifies: SAT-28271
:customerscenario: true

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewisely looks good, one question and PRT pending.

Comment on lines +355 to +359
result = session.contentview_new.check_publish_banner(cv.name)
assert result
cv.publish()
result2 = session.contentview_new.check_publish_banner(cv.name)
assert not result2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the logic be the opposite? The "no changes" warning displayed after publish, not before?

Suggested change
result = session.contentview_new.check_publish_banner(cv.name)
assert result
cv.publish()
result2 = session.contentview_new.check_publish_banner(cv.name)
assert not result2
result = session.contentview_new.check_publish_banner(cv.name)
assert not result
cv.publish()
result2 = session.contentview_new.check_publish_banner(cv.name)
assert result2

@vsedmik
Copy link
Contributor

vsedmik commented Dec 19, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k test_cv_publish_warning
airgun: 1653

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9674
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_cv_publish_warning --external-logging
Test Result : =========== 1 failed, 7 deselected, 17 warnings in 649.18s (0:10:49) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants