-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test checking needs publish banner on cv index page #17154
base: master
Are you sure you want to change the base?
Conversation
@sambible To which branches do you want this PR to be merged? |
|
||
|
||
@pytest.mark.upgrade | ||
@pytest.mark.tier2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pytest.mark.tier2 |
We don't use tier markers anymore.
result = session.contentview_new.check_publish_banner(cv.name) | ||
assert result | ||
cv.publish() | ||
result2 = session.contentview_new.check_publish_banner(cv.name) | ||
assert not result2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
result = session.contentview_new.check_publish_banner(cv.name) | |
assert result | |
cv.publish() | |
result2 = session.contentview_new.check_publish_banner(cv.name) | |
assert not result2 | |
assert session.contentview_new.check_publish_banner(cv.name) | |
cv.publish() | |
assert not session.contentview_new.check_publish_banner(cv.name) |
4. Check the publish wizard again for the CV and verify the warning isn't visible | ||
|
||
:expectedresults: The publish warning banner accurately reflects the status of the CV | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:Verifies: SAT-28271 | |
:customerscenario: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewisely looks good, one question and PRT pending.
result = session.contentview_new.check_publish_banner(cv.name) | ||
assert result | ||
cv.publish() | ||
result2 = session.contentview_new.check_publish_banner(cv.name) | ||
assert not result2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the logic be the opposite? The "no changes" warning displayed after publish, not before?
result = session.contentview_new.check_publish_banner(cv.name) | |
assert result | |
cv.publish() | |
result2 = session.contentview_new.check_publish_banner(cv.name) | |
assert not result2 | |
result = session.contentview_new.check_publish_banner(cv.name) | |
assert not result | |
cv.publish() | |
result2 = session.contentview_new.check_publish_banner(cv.name) | |
assert result2 |
|
PRT Result
|
Problem Statement
Test supporting this Customer Issue: https://issues.redhat.com/browse/SAT-28271
Solution
Adds a test validating this issue+
Related Issues
Requires Airgun PR: SatelliteQE/airgun#1653