updated curl to register host with name param instead id #17152
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolpati30
added
QETestCoverage
amolpati30
force-pushed
the
register_host_with_curl_with_name_param
branch
from
3ee8c57 to
7c974c2
Compare
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
pondrejk
reviewed
Dec 12, 2024
shweta83
reviewed
Dec 16, 2024
shweta83
reviewed
Dec 16, 2024
amolpati30
force-pushed
the
register_host_with_curl_with_name_param
branch
from
7c974c2 to
e3ca50c
Compare
Satellite-QE
removed
the
PRT-Passed
|
PRT Result |
Satellite-QE
added
the
PRT-Failed
|
PRT Result |
tests/foreman/ui/test_fact.py
Outdated
Comment on lines
62
to
68
| result = cmd[cmd.find('hostgroup_id=') : cmd.find('&update_packages=')] | ||
| if ' ' in default_os.title: | ||
| default_os.title = default_os.title.replace(' ', '+') | ||
| new_data = f'hostgroup={hostgroup.name}&location={module_location.name}&operatingsystem={default_os.title}&organization={module_sca_manifest_org.name}' | ||
| updated_cmd = cmd.replace(result, new_data) | ||
| assert new_data in updated_cmd | ||
| result = rhel_contenthost.execute(updated_cmd) |
There was a problem hiding this comment.
If we're switching the generated curl command manually for verifying this RFE, I'd suggest to create a new test for this in test_registration module, as it could impact the existing test and it looks unrelated to facts component, OR if I'm missing some context about this test please correct me
There was a problem hiding this comment.
+1 to create a new test for it.
There was a problem hiding this comment.
@Gauravtalreja1 @shweta83
It was a small section, so I added it to the existing test instead of creating a new one. I don’t believe this change would impact the existing test since the PRT passed previously. Currently, it’s failing due to some internal issues, but otherwise, it should work. However, if you think I should create a new test for this, I’m happy to do so.
tests/foreman/ui/test_fact.py
Outdated
| result = rhel_contenthost.execute(cmd) | ||
| result = cmd[cmd.find('hostgroup_id=') : cmd.find('&update_packages=')] | ||
| if ' ' in default_os.title: | ||
| default_os.title = default_os.title.replace(' ', '+') |
There was a problem hiding this comment.
Suggested change
| default_os.title = default_os.title.replace(' ', '+') | |
| new_os_title = default_os.title.replace(' ', '+') |
amolpati30
force-pushed
the
register_host_with_curl_with_name_param
branch
6 times, most recently
from
c6c3724 to
fba5cba
Compare
amolpati30
force-pushed
the
register_host_with_curl_with_name_param
branch
from
fba5cba to
713652b
Compare
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
PRT-Passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The host is successfully registering using the label/name instead of the ID, and this applies to the following parameters: